Move _tensor_impl extensions and use it for dpnp#2755
Move _tensor_impl extensions and use it for dpnp#2755vlad-perevezentsev wants to merge 18 commits intoinclude-dpctl-tensorfrom
_tensor_impl extensions and use it for dpnp#2755Conversation
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2755/index.html |
|
Array API standard conformance tests for dpnp=0.20.0dev2=py313h509198e_26 ran successfully. |
97c1668 to
6680790
Compare
| import dpctl.tensor._tensor_impl as dti | ||
|
|
||
| # pylint: disable=no-name-in-module | ||
| import dpctl_ext.tensor._tensor_impl as dti |
There was a problem hiding this comment.
Missed to update:
- dpnp/tests/test_array_api_info.py
- dpnp/linalg/dpnp_utils_linalg.py
- dpnp/fft/dpnp_utils_fft.py
- dpnp/dpnp_algo/dpnp_fill.py
- dpnp/dpnp_iface_indexing.py
If intended, it has to be clearly stated with explicit TODO comment.
There was a problem hiding this comment.
I have updated dpnp/tests/test_array_api_info.py
The other files have been updated to #2758
| # CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF | ||
| # THE POSSIBILITY OF SUCH DAMAGE. | ||
| # ***************************************************************************** |
There was a problem hiding this comment.
Why is it empty? It leads to
import dpctl_ext.tensor as dpe
dir(dpe)
# Out[6]:
# ['__builtins__',
# '__cached__',
# '__doc__',
# '__file__',
# '__loader__',
# '__name__',
# '__package__',
# '__path__',
# '__spec__']There was a problem hiding this comment.
Because this PR does not add public functions to dpctl_ext.tensor
_init_.py will be expanded in the following PRs
For example in #2758 https://github.com/IntelPython/dpnp/pull/2758/changes#diff-83d3837f45456ab786416e3e3fa6c6111e65c03b2404af195fb7d16dfb58b00b
This PR proposes introducing
dpctl_extas a new internal extension module (temporarily renamed fromdpctlto avoid conflicts), adding CMake/packaging support for building_tensor_implvia pybind11 and switching dpnp to usedpctl_ext.tensor. _tensor_implThe migrated
_tensor_implcurrently supports the following functions:Files in

dpnpthat explicitlyimport dpctl.tensor._tensor_implGreen items are handled in this PR
Red items will be handled in the next PR (#2758 )