Skip to content

Update datasetType model#432

Merged
jp-tosca merged 3 commits intodevelopfrom
DatasetTypeModelUpdate
Mar 12, 2026
Merged

Update datasetType model#432
jp-tosca merged 3 commits intodevelopfrom
DatasetTypeModelUpdate

Conversation

@ChengShi-1
Copy link
Contributor

What this PR does / why we need it:

Backend API results updated, the use case DatasetType model should be updated accordingly.

Which issue(s) this PR closes:

  • Closes #

Related Dataverse PRs:

  • Depends on #

Special notes for your reviewer:

Suggestions on how to test this:

Is there a release notes or changelog update needed for this change?:

Additional documentation:

Copilot AI review requested due to automatic review settings March 12, 2026 15:37
@ChengShi-1 ChengShi-1 added GREI Re-arch GREI re-architecture-related FY26 Sprint 19 FY26 Sprint 19 (2026-03-11 - 2026-03-25) labels Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the DatasetType domain model and related tests to reflect newly returned fields from the backend API (displayName and description) and adjusts test data creation to use randomUUID from node:crypto.

Changes:

  • Extend DatasetType model with displayName and description.
  • Update unit/integration/functional tests’ expected dataset type payloads to include the new fields.
  • Replace usage of crypto.randomUUID() with an explicit randomUUID import in several tests.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/datasets/domain/models/DatasetType.ts Extends the exported DatasetType interface with displayName and description.
test/unit/datasets/GetDatasetAvailableDatasetTypes.test.ts Updates expected dataset types to include displayName and description.
test/unit/datasets/GetDatasetAvailableDatasetType.test.ts Updates expected dataset type to include displayName and description.
test/integration/datasets/DatasetsRepository.test.ts Updates expected dataset type(s) and adds randomUUID import for test dataset type creation.
test/functional/datasets/SetAvailableLicensesForDatasetType.test.ts Adds randomUUID import and includes displayName/description in add-dataset-type payload.
test/functional/datasets/LinkDatasetTypeWithMetadataBlocks.test.ts Adds randomUUID import and includes displayName/description in add-dataset-type payload.
test/functional/datasets/GetDatasetAvailableDatasetTypes.test.ts Updates expected dataset type to include displayName and description.
test/functional/datasets/GetDatasetAvailableDatasetType.test.ts Updates expected dataset type to include displayName and description.
test/functional/datasets/DeleteDatasetType.test.ts Adds randomUUID import and includes displayName/description in add-dataset-type payload.
test/functional/datasets/AddDatasetType.test.ts Adds randomUUID import and includes displayName/description in add-dataset-type payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@ChengShi-1 ChengShi-1 added the Size: 0.5 A percentage of a sprint. 0.35 hours label Mar 12, 2026
@ChengShi-1 ChengShi-1 moved this to Ready for Review ⏩ in IQSS Dataverse Project Mar 12, 2026
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approved!

@github-project-automation github-project-automation bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Mar 12, 2026
@jp-tosca jp-tosca self-assigned this Mar 12, 2026
@jp-tosca jp-tosca moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Mar 12, 2026
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@jp-tosca jp-tosca merged commit 67721ee into develop Mar 12, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Mar 12, 2026
@jp-tosca jp-tosca removed their assignment Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 19 FY26 Sprint 19 (2026-03-11 - 2026-03-25) GREI Re-arch GREI re-architecture-related Project: Trusted Data Size: 0.5 A percentage of a sprint. 0.35 hours

Projects

Status: Merged 🚀

Development

Successfully merging this pull request may close these issues.

5 participants