Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the DatasetType domain model and related tests to reflect newly returned fields from the backend API (displayName and description) and adjusts test data creation to use randomUUID from node:crypto.
Changes:
- Extend
DatasetTypemodel withdisplayNameanddescription. - Update unit/integration/functional tests’ expected dataset type payloads to include the new fields.
- Replace usage of
crypto.randomUUID()with an explicitrandomUUIDimport in several tests.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/datasets/domain/models/DatasetType.ts |
Extends the exported DatasetType interface with displayName and description. |
test/unit/datasets/GetDatasetAvailableDatasetTypes.test.ts |
Updates expected dataset types to include displayName and description. |
test/unit/datasets/GetDatasetAvailableDatasetType.test.ts |
Updates expected dataset type to include displayName and description. |
test/integration/datasets/DatasetsRepository.test.ts |
Updates expected dataset type(s) and adds randomUUID import for test dataset type creation. |
test/functional/datasets/SetAvailableLicensesForDatasetType.test.ts |
Adds randomUUID import and includes displayName/description in add-dataset-type payload. |
test/functional/datasets/LinkDatasetTypeWithMetadataBlocks.test.ts |
Adds randomUUID import and includes displayName/description in add-dataset-type payload. |
test/functional/datasets/GetDatasetAvailableDatasetTypes.test.ts |
Updates expected dataset type to include displayName and description. |
test/functional/datasets/GetDatasetAvailableDatasetType.test.ts |
Updates expected dataset type to include displayName and description. |
test/functional/datasets/DeleteDatasetType.test.ts |
Adds randomUUID import and includes displayName/description in add-dataset-type payload. |
test/functional/datasets/AddDatasetType.test.ts |
Adds randomUUID import and includes displayName/description in add-dataset-type payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ekraffmiller
approved these changes
Mar 12, 2026
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
pdurbin
reviewed
Mar 12, 2026
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backend API results updated, the use case DatasetType model should be updated accordingly.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes or changelog update needed for this change?:
Additional documentation: