Update manifests to conform to stricter requirements of Presentation 4 Properties#74
Closed
vincentmarchetti wants to merge 1 commit intomainfrom
Closed
Update manifests to conform to stricter requirements of Presentation 4 Properties#74vincentmarchetti wants to merge 1 commit intomainfrom
vincentmarchetti wants to merge 1 commit intomainfrom
Conversation
interpreted as the id of a SceneResource Section 4.2 of the Presentation 4.0 Properties document https://preview.iiif.io/api/prezi-4/presentation/4.0/properties/#42-resource-representations no longer allow this. The target property has been set to the JSON representation of an object with type and id properties
Contributor
Author
|
I am closing this PR without merge as this fix is already applied in #73, a PR that has now been merged |
Contributor
Author
|
I have reopened this PR, the fix #73 did fix the duplication of id values, but after that commit the target property is a bare string, not a JSON object as now required by the (draft) presentation 4 |
Contributor
Author
|
This PR could not be reopened because the branch had been deleted. Instead there is a new PR #75 addressing the issue, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of these manifests had a target property that was a string
interpreted as the id of a Scene resource
Section 4.2 of the Presentation 4.0 Properties document https://preview.iiif.io/api/prezi-4/presentation/4.0/properties/#42-resource-representations no longer allow this.
The target property has been set to the JSON representation of an object with type and id properties