Simplify layer structure encoding and decoding #3745
Draft
+40
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3742
This PR replaces the custom, over-engineered 1D bit-packed encoding for the layer structure with a standard hierarchical tree structure.
Previously, the layer hierarchy was encoded into a
u64buffer where the Most Significant Bit (MSB) indicated indentation changes and the values represented layer counts or IDs. This was decoded manually in the frontend using DataView and pointer arithmetic.Now, the structure is defined as a simple recursive
LayerStructurestruct in Rust and class in TypeScript, which is automatically serialized and deserialized viaserdeand class-transformer.