Fix Log4j2PluginsCacheFileTransformer not working for merging Log4j2Plugins.dat files#1955
Merged
Fix Log4j2PluginsCacheFileTransformer not working for merging Log4j2Plugins.dat files#1955
Log4j2PluginsCacheFileTransformer not working for merging Log4j2Plugins.dat files#1955Conversation
Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Port feature for plugin written in Groovy to branch 1175
Port Log4j2PluginsCacheFileTransformer fixes (#1175) to Groovy branch
Mar 3, 2026
Add a fix for Log4j2PluginsCacheFileTransformer issue.
Log4j2PluginsCacheFileTransformer not working for merging Log4j2Plugins.dat files
Goooler
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the
Log4j2PluginsCacheFileTransformerfixes from #1175 to the Groovy plugin branch.Transformer fixes (
Log4j2PluginsCacheFileTransformer.groovy)canTransformResource: Useelement.relativePath.pathStringinstead ofelement.name— prevents false matches on.datfiles with the same name in unrelated pathshasTransformedResource: Simplify to!temporaryFiles.isEmpty()— old logic incorrectly returnedfalsefor single-file transforms without relocatorsmodifyOutputStream: Wrap in try/finally so temp files are always cleaned updeleteTempFiles(): New helper that removes files from both the list and filesystem (vs. justclear())relocatePlugins: Made package-accessible for testingTest updates (
Log4j2PluginsCacheFileTransformerSpec.groovy)TransformerSpecSupportto getgetFileElement()helpercanTransformResourcetest asserting full-path matching semanticsshould not transformer/should transformwithtransformAndModifyOutputStreamcovering the full pipelinerelocationsparameterized test (matching and non-matching pattern cases)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
scans-in.gradle.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.