Fix field access flags preservation and module exports/opens relocation in RelocatorRemapper

[Copilot]

Two correctness bugs in the Class-File API-based RelocatorRemapper:

• Field flags preserved: withField(...) was not forwarding the original access flags (public, static, final, etc.), potentially emitting fields with incorrect modifiers. Fixed by using withField(String, ClassDesc, Consumer) and calling fb.withFlags(cle.flags().flagsMask()) inside the lambda — necessary because ClassBuilder.withField has no (String, ClassDesc, int, Consumer) overload unlike withMethod.

• Module exports/opens relocated: ModuleAttribute handling passed exports() and opens() through unchanged. These carry package names in internal format; if packages are relocated, the module descriptor would still reference pre-relocation packages, breaking JPMS at runtime. Fixed by remapping each entry via PackageDesc.ofInternalName(map(...)) and reconstructing ModuleExportInfo/ModuleOpenInfo.

---

• CHANGELOG's "Unreleased" section has been updated, if applicable.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• dl.google.com
  • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en (dns block)
• scans-in.gradle.com
  • Triggering command: /usr/lib/jvm/temurin-25-jdk-amd64/bin/java /usr/lib/jvm/temurin-25-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED --enable-native-access=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Goooler]

@copilot Fix the issues

[Copilot]

@copilot Fix the issues

Fixed in commit 5c2104c. Two CI failures:

1. Compilation error: ClassBuilder.withField() has no (String, ClassDesc, int, Consumer) overload (unlike withMethod). Fixed by using withField(String, ClassDesc, Consumer) and calling fb.withFlags(cle.flags().flagsMask()) inside the lambda to preserve access flags.

2. Spotless format violation: The long clb.constantPool().packageEntry(PackageDesc.ofInternalName(...)) lines exceeded the line length limit. Reformatted as chained method calls split across multiple lines.