Skip to content

Fix broken reference links in docs and use applyShadowPlugin=false for consuming projects in tests#1942

Closed
Copilot wants to merge 2 commits intog/20260301/doc-shadow-jar-defaultfrom
copilot/sub-pr-1941
Closed

Fix broken reference links in docs and use applyShadowPlugin=false for consuming projects in tests#1942
Copilot wants to merge 2 commits intog/20260301/doc-shadow-jar-defaultfrom
copilot/sub-pr-1941

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

Two unresolved review issues from the original PR adding documentation for making shadowJar the default project artifact.

  • Docs (docs/multi-project/README.md): Three reference-style links were used but never defined, causing broken links in published docs. Added definitions for:

    • [gradle-consumable-configs] → Gradle terminology: consumable configuration
    • [gradle-declarable-configs] → Gradle terminology: declarable configuration
    • [gradle-exclude-rules] → Gradle docs: excluding transitive dependencies
  • Tests (JavaPluginsTest.kt): The server consuming project in consumeShadowedProjectViaApiElementsAndRuntimeElements was applying the Shadow plugin unnecessarily via getDefaultProjectBuildScript("java"). Switched to applyShadowPlugin = false to keep the test representative of a plain Java consumer.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…r consuming projects in tests

Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 1, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
  • scans-in.gradle.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Document how to make a shadowed JAR the default output Fix broken reference links in docs and use applyShadowPlugin=false for consuming projects in tests Mar 1, 2026
@Goooler Goooler closed this Mar 1, 2026
@Goooler Goooler deleted the copilot/sub-pr-1941 branch March 1, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants