Modernize Kotlin DSL examples in the README#40
Modernize Kotlin DSL examples in the README#40sschuberth wants to merge 4 commits intoGradleUp:mainfrom
Conversation
9d9d328 to
2b414f1
Compare
|
Thanks for opening this! Unfortunately, I'm in the other team and I like the old boring verbose syntax better for multiple reasons, the main one being that I can copy paste into any context and it will work without any additional compiler plugin and/or dependency. It's much more simple. It doesn't look like a DSL but I found out the hard way that Gradle build scripts are not really declarative given they are reliant on the order of different calls at the end of the day. Maybe that will change with declarative Gradle and I'll happily provide support for that but until then, I prefer to keep it this way. |
That's sad to hear, esp. as I thought GradleUp would also be about spreading the word about Gradle best-practices and idiomatic use of Kotlin DSL, and to me best-practices is not to stick to outdated syntax, even if that would widen the range of supported Gradle versions. Anyway, let me split out some of the (hopefully) uncontroversial commit to a new PR for your review. |
See #41. |
|
Thanks for splitting up those commits, they are merged. As for the rest, I think it's good that we can have this conversation and I will keep it as is. If consensus emerges that everyone prefers the other syntax, I'll revisit! Thanks! |
Please have a look at the individual commit messages for the details.