Skip to content

feat(saas-billing): Invoice immediately for new seats#7086

Open
matthewelwell wants to merge 2 commits intomainfrom
feat/invoice-immediately-for-new-seats
Open

feat(saas-billing): Invoice immediately for new seats#7086
matthewelwell wants to merge 2 commits intomainfrom
feat/invoice-immediately-for-new-seats

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

Changes

Resolves https://github.com/Flagsmith/flagsmith-private/issues/108

  • Invoices scale-up customers immediately for new seats instead of pro-rating to the next billing cycle.
  • Uses a new addon which ensures that addons are billed according to the correct billing frequency

How did you test this code?

Existing unit tests should cover the behaviour, but I will also test manually in staging.

@matthewelwell matthewelwell requested a review from a team as a code owner March 31, 2026 17:34
@matthewelwell matthewelwell requested review from emyller and removed request for a team March 31, 2026 17:34
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Mar 31, 2026 5:34pm
flagsmith-frontend-preview Ignored Ignored Mar 31, 2026 5:34pm
flagsmith-frontend-staging Ignored Ignored Mar 31, 2026 5:34pm

Request Review

@matthewelwell matthewelwell changed the title Feat/invoice immediately for new seats feat(saas-billing): Invoice immediately for new seats Mar 31, 2026
@github-actions github-actions bot added the api Issue related to the REST API label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7086 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7086 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7086 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7086 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7086 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7086 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (3caa120) to head (a7885eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7086   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files        1335     1335           
  Lines       49943    49943           
=======================================
  Hits        49113    49113           
  Misses        830      830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  42.1 seconds
commit  a7885eb
info  🔄 Run: #15596 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  42.9 seconds
commit  a7885eb
info  🔄 Run: #15596 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.2 seconds
commit  a7885eb
info  🔄 Run: #15596 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  54.3 seconds
commit  a7885eb
info  🔄 Run: #15596 (attempt 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant