fix: Preserve native types for multivariate feature option values#205
Merged
matthewelwell merged 3 commits intoFlagsmith:mainfrom Apr 2, 2026
Merged
fix: Preserve native types for multivariate feature option values#205matthewelwell merged 3 commits intoFlagsmith:mainfrom
matthewelwell merged 3 commits intoFlagsmith:mainfrom
Conversation
MultivariateFeatureOptionModel.value was typed as String, causing Jackson to coerce boolean and integer JSON values to their string representations (e.g. true -> "true", 42 -> "42") during deserialization of the environment document. This affected only the local evaluation path where multivariate variant values flow through EngineMappers into the flag engine. The control value (feature_state_value) was unaffected because FeatureStateModel already uses Object for its value field. Changing the field type to Object lets Jackson preserve the original JSON type through the entire evaluation pipeline.
This reverts commit 342ac23.
matthewelwell
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultivariateFeatureOptionModel.value was typed as String, causing Jackson to coerce boolean and integer JSON values to their string representations (e.g. true -> "true", 42 -> "42") during deserialization of the environment document.
This affected only the local evaluation path where multivariate variant values flow through EngineMappers into the flag engine. The control value (feature_state_value) was unaffected because FeatureStateModel already uses Object for its value field.
Changing the field type to Object lets Jackson preserve the original JSON type through the entire evaluation pipeline.