Fix for #615: Use ValueInstantiators to rename creator properties so they match property definitions#806
Open
mcvayc wants to merge 2 commits intoFasterXML:3.xfrom
Open
Fix for #615: Use ValueInstantiators to rename creator properties so they match property definitions#806mcvayc wants to merge 2 commits intoFasterXML:3.xfrom
mcvayc wants to merge 2 commits intoFasterXML:3.xfrom
Conversation
mcvayc
commented
Mar 15, 2026
| // Second check: rename map from property definitions | ||
| String newName = renames.get(propName); | ||
| if (newName != null && !newName.equals(propName)) { | ||
| creatorProps[i] = prop.withSimpleName(newName); |
Author
There was a problem hiding this comment.
Other than directly editing the array items, is there a better way to update the creator properties of the instantiator? I didn't see a setter.
mcvayc
commented
Mar 15, 2026
| // [dataformat-xml#423] | ||
| @JacksonTestFailureExpected | ||
| @Test | ||
| public void testXmlTextViaCtor423() throws Exception |
Author
There was a problem hiding this comment.
This test started passing so I split it out so it could be removed from the tofix package.
Author
There was a problem hiding this comment.
The test now resides in src/test/java/tools/jackson/dataformat/xml/deser/XmlTextViaCtor423Test.java
Author
|
I see the build errors, let me take a look. |
…perties so they match property definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR was intended to fix #615 but in the process tests for #149, #517, and #735 in the
tofixpackage started passing as well. I've listed all the issues for which test are now passing in the commits, but still need to verify for those that the entire issue is fixed.The initial solution was co-written by Claude Code and me. After collaboratively creating a fix, I subsequently read through the code and edited it for quality and consistency. I believe the solution is now in decent shape, at least for #615.
Please let me know what you think. I'm happy to make further edits.