Skip to content

Fix path traversal in KMS remove_cache (#558) #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvinwang wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −9
Open

Fix path traversal in KMS remove_cache (#558) #601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ff829
fix: prevent path traversal in KMS remove_cache
kvinwang Mar 26, 2026
01a89cb
kms: restrict clear_image_cache key to hex
kvinwang Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions kms/src/main_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
//
// SPDX-License-Identifier: Apache-2.0

use std::{path::PathBuf, sync::Arc};
use std::{
path::{Path, PathBuf},
sync::Arc,
};

use anyhow::{bail, Context, Result};
use dstack_kms_rpc::{
Expand Down Expand Up @@ -142,20 +145,28 @@ impl RpcHandler {
self.state.config.image.cache_dir.join("images")
}

fn remove_cache(&self, parent_dir: &PathBuf, sub_dir: &str) -> Result<()> {
fn remove_cache(&self, parent_dir: &Path, sub_dir: &str) -> Result<()> {
if sub_dir.is_empty() {
return Ok(());
}

if sub_dir == "all" {
fs::remove_dir_all(parent_dir)?;
} else {
let path = parent_dir.join(sub_dir);
if path.is_dir() {
fs::remove_dir_all(path)?;
} else {
fs::remove_file(path)?;
}
return Ok(());
}

if !sub_dir.chars().all(|c| c.is_ascii_hexdigit()) {
bail!("Invalid cache key");
}

let path = parent_dir.join(sub_dir);

if path.is_dir() {
fs::remove_dir_all(path)?;
} else if path.is_file() {
fs::remove_file(path)?;
}

Ok(())
}

Expand Down
Loading