fix: Serialize plan results to JSON compatible types earlier#1464
Open
fix: Serialize plan results to JSON compatible types earlier#1464
Conversation
When a plan returns a value that is serializable but contains a nested value that is not (eg a list of an unserializable type), the check for whether it could be serialized was too lenient and the unserializable type would be stored only to fail later when it was sent to the message bus. Converting the result to a json compatible type (using mode='json') earlier allows any issues with nested fields to be caught and handled appropriately.
tpoliaw
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1464 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 43 43
Lines 3128 3129 +1
=======================================
+ Hits 2978 2979 +1
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Can we please add a test with a plan |
abbiemery
requested changes
Apr 1, 2026
Contributor
abbiemery
left a comment
abbiemery
left a comment
There was a problem hiding this comment.
Looks like it works, please can you add a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plan returns a value that is serializable but contains a nested
value that is not (eg a list of an unserializable type), the check for
whether it could be serialized was too lenient and the unserializable
type would be stored only to fail later when it was sent to the message
bus.
Converting the result to a json compatible type (using mode='json')
earlier allows any issues with nested fields to be caught and handled
appropriately.
Fixes #1447