Scheduler - Rewrite deleteAppointments.ts testcafe tests to jest #33105
Merged
Tucchhaa merged 4 commits intoDevExpress:26_1from Apr 1, 2026
Merged
Scheduler - Rewrite deleteAppointments.ts testcafe tests to jest #33105Tucchhaa merged 4 commits intoDevExpress:26_1from
Tucchhaa merged 4 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Scheduler “delete appointments” coverage from TestCafe E2E to Jest-based internal scheduler tests.
Changes:
- Reorganized and expanded keyboard-navigation tests in
appointments.test.ts, adding Delete hotkey coverage (single and recurring cases). - Expanded
appointment_tooltip.test.tsto cover deleting from the collector tooltip (button click, Delete key, allowDeleting=false, disabled appointments, recurring deletion dialogs). - Extended the Jest test POM (
PopupModel) with recurrence delete dialog button accessors and removed the old TestCafe suite.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/tests/appointments.test.ts | Adds Jest coverage for Delete hotkey behavior and groups Home/End hotkey tests. |
| packages/devextreme/js/__internal/scheduler/tests/appointment_tooltip.test.ts | Adds Jest coverage for deleting appointments via tooltip interactions, including recurrence dialogs and guard cases. |
| packages/devextreme/js/__internal/scheduler/tests/mock/model/popup.ts | Adds POM getters for “Delete series” / “Delete appointment” dialog buttons used by new tests. |
| e2e/testcafe-devextreme/tests/scheduler/common/deleteAppointments.ts | Removes the superseded TestCafe E2E tests. |
sjbur
reviewed
Apr 1, 2026
| it('should delete appointment on Delete', async () => { | ||
| const { POM, keydown } = await createScheduler({ | ||
| dataSource: [{ | ||
| text: 'Recurring Appointment', |
Contributor
There was a problem hiding this comment.
minor: it is not a recurring appointment
| POM.getCollectorButton().click(); | ||
| POM.tooltip.getDeleteButton().click(); | ||
| const { POM, scheduler } = await createScheduler({ | ||
| dataSource: data, |
Contributor
There was a problem hiding this comment.
minor: in all other tests we use spread operator on data in dataSource. Can you do same here?
aleksei-semikozov
previously approved these changes
Apr 1, 2026
sjbur
reviewed
Apr 1, 2026
| ]); | ||
|
|
||
| expect((scheduler as any).getDataSource().items()).toEqual([...data]); | ||
| expect(Boolean(items[1].recurrenceException)).toBe(true); |
Contributor
There was a problem hiding this comment.
How about changing this line to something like
expect(items[1].recurrenceException).toContain('20170522');
I saw that before there was an exception validation. This will be more secure
Contributor
Author
There was a problem hiding this comment.
Good suggestion, thanks. I've applied it
sjbur
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.