Skip to content

Scheduler: add Resolve Time Conflicts demo description + update function name#33093

Open
vladaskorohodova wants to merge 3 commits intoDevExpress:26_1from
vladaskorohodova:scheduler-appointment-overlap26_1
Open

Scheduler: add Resolve Time Conflicts demo description + update function name#33093
vladaskorohodova wants to merge 3 commits intoDevExpress:26_1from
vladaskorohodova:scheduler-appointment-overlap26_1

Conversation

@vladaskorohodova
Copy link
Copy Markdown
Contributor

No description provided.

@vladaskorohodova vladaskorohodova self-assigned this Mar 30, 2026
@vladaskorohodova vladaskorohodova requested a review from a team as a code owner March 30, 2026 10:36
Copilot AI review requested due to automatic review settings March 30, 2026 10:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-user documentation for the “Resolve Time Conflicts” Scheduler demo and standardizes a helper function name across framework implementations.

Changes:

  • Added description.md for the Resolve Time Conflicts demo, explaining conflict detection, overlapping rules, and error display behavior.
  • Renamed alertConflictIfNeededhandleConflict across Angular/React/ReactJs/Vue/jQuery demo sources to better reflect behavior.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/demos/Demos/Scheduler/ResolveTimeConflicts/jQuery/index.js Renames conflict-handling helper and updates event handlers to call it.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/description.md New demo description documenting conflict detection and UI behavior.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/Vue/App.vue Renames conflict-handling helper and updates event handlers to call it.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/ReactJs/App.js Renames conflict-handling callback and updates handlers/deps.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/React/App.tsx Renames conflict-handling callback and updates handlers/deps.
apps/demos/Demos/Scheduler/ResolveTimeConflicts/Angular/app/app.component.ts Renames conflict-handling method and updates event handlers to call it.

Tucchhaa
Tucchhaa previously approved these changes Mar 30, 2026
Co-authored-by: Vladimir Abadzhev <vladimira@devexpress.com>
Signed-off-by: Vlada Skorokhodova <94827090+vladaskorohodova@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 1, 2026 06:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

},
onAppointmentUpdating(e) {
alertConflictIfNeeded(e, e.newData);
handleConflict(e, e.newData);
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onAppointmentUpdating passes e.newData directly into conflict detection. In Scheduler, newData can be partial (only changed fields), so detectConflict() may receive an appointment without startDate/endDate/assigneeId and miss conflicts. Consider passing a merged object (e.g., old + new) here, consistent with the React/Vue/Angular versions of this demo.

Suggested change
handleConflict(e, e.newData);
const updatedAppointment = $.extend({}, e.appointmentData, e.newData);
handleConflict(e, updatedAppointment);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants