DataGrid: fix rows disappear on collapse group and virtual scroll (T1325181)#33075
Open
anna-shakhova wants to merge 2 commits intoDevExpress:26_1from
Open
DataGrid: fix rows disappear on collapse group and virtual scroll (T1325181)#33075anna-shakhova wants to merge 2 commits intoDevExpress:26_1from
anna-shakhova wants to merge 2 commits intoDevExpress:26_1from
Conversation
70ad332 to
620871f
Compare
620871f to
51d8754
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a DataGrid regression where grouped rows could disappear after collapsing/expanding groups while using virtual scrolling (local grouping with remote operations). The change refines how group offsets and virtual “loadIndex” are computed during group state transitions and adds coverage to prevent regressions.
Changes:
- Adjust virtual scrolling loadIndex progression for group rows to avoid incorrect index shifts.
- Rework expanded-group offset recalculation to account for “pending” expand/collapse state during loading.
- Add new typing helpers plus Jest + TestCafe regression tests for the disappearing-rows scenario.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/m_virtual_scrolling.ts |
Tweaks group-row loadIndex increment conditions in the new virtual mode. |
packages/devextreme/js/__internal/grids/data_grid/grouping/types.ts |
Introduces TS types for grouping items and group info (used by expanded grouping helper). |
packages/devextreme/js/__internal/grids/data_grid/grouping/m_grouping_expanded.ts |
Updates group offset recalculation and loading-window logic using an isPending marker during expand/collapse. |
packages/devextreme/js/__internal/grids/data_grid/grouping/m_grouping_expanded.test.ts |
Adds Jest unit tests covering offset calculations and pending-state loading behavior. |
packages/devextreme/js/__internal/grids/data_grid/grouping/m_grouping_core.ts |
Adds a return type to findGroupInfo for the new grouping types. |
e2e/testcafe-devextreme/tests/dataGrid/common/scrolling.ts |
Adds an E2E regression test to ensure the last group doesn’t disappear after collapsing a subgroup in virtual mode. |
packages/devextreme/js/__internal/grids/data_grid/grouping/m_grouping_expanded.test.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.