Skip to content

Comments

refactor(profiling): use libdd-profiling's ThinStr#3631

Merged
morrisonlevi merged 1 commit intomasterfrom
levi/thin-str-cleanup
Feb 13, 2026
Merged

refactor(profiling): use libdd-profiling's ThinStr#3631
morrisonlevi merged 1 commit intomasterfrom
levi/thin-str-cleanup

Conversation

@morrisonlevi
Copy link
Collaborator

Description

This replaces the ThinStr defined in this module with the one that is in libdd-profiling instead. Note that the one in libdd-profiling was a copy + refactor of this one, which is why the migration is so easy.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi added the profiling Relates to the Continuous Profiler label Feb 7, 2026
@datadog-official
Copy link

datadog-official bot commented Feb 7, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1026 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 698e0477000000003e63a0e4e0aa906b
tid: 698e047700000000
hexProcessTraceId: 3e63a0e4e0aa906b
hexProcessSpanId: 82011110e3bfdd43
processTraceId: 4495613757928149099
processSpanId: 9367787464145493315

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 69d9061 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-02-12 16:48:28

Comparing candidate commit 69d9061 in PR branch levi/thin-str-cleanup with baseline commit cf7ba04 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 25 metrics, 7 unstable metrics.

scenario:php-profiler-timeline-memory-control

  • 🟥 cpu_user_time [+24.856ms; +30.568ms] or [+4.025%; +4.950%]
  • 🟥 execution_time [+27.703ms; +35.616ms] or [+4.312%; +5.543%]

scenario:php-profiler-timeline-memory-with-profiler

  • 🟥 execution_time [+22.036ms; +35.781ms] or [+2.177%; +3.535%]

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟥 execution_time [+28.706ms; +52.046ms] or [+2.223%; +4.031%]

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (cf7ba04) to head (69d9061).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3631   +/-   ##
=======================================
  Coverage   62.11%   62.11%           
=======================================
  Files         141      141           
  Lines       13387    13387           
  Branches     1753     1753           
=======================================
  Hits         8315     8315           
  Misses       4273     4273           
  Partials      799      799           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7ba04...69d9061. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@morrisonlevi morrisonlevi marked this pull request as ready for review February 12, 2026 15:21
@morrisonlevi morrisonlevi requested a review from a team as a code owner February 12, 2026 15:21
@morrisonlevi morrisonlevi merged commit 2cb776a into master Feb 13, 2026
2068 of 2070 checks passed
@morrisonlevi morrisonlevi deleted the levi/thin-str-cleanup branch February 13, 2026 16:11
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants