Skip to content

Adds process_tags to crashtracking tags#3582

Merged
dubloom merged 23 commits intomasterfrom
dubloom/process-tags-crashtracking
Feb 17, 2026
Merged

Adds process_tags to crashtracking tags#3582
dubloom merged 23 commits intomasterfrom
dubloom/process-tags-crashtracking

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 19, 2026

This PR implements this RFC for crashtracking.

Add process_tags to crashtracking tags

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 19, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6994a31f0000000032f1c48df44cbec8
tid: 6994a31f00000000
hexProcessTraceId: 32f1c48df44cbec8
hexProcessSpanId: 0f55bd872d5a718c
processTraceId: 3670931285251768008
processSpanId: 1104997671868461452

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 6994a3bb00000000530dbdc982113258
tid: 6994a3bb00000000
hexProcessTraceId: 530dbdc982113258
hexProcessSpanId: 34dbcc0bea4b238a
processTraceId: 5984648153013498456
processSpanId: 3808862261419385738
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 31ca15c | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (7ed10a0) to head (31ca15c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3582      +/-   ##
==========================================
+ Coverage   62.12%   62.20%   +0.07%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
+ Hits         8317     8327      +10     
+ Misses       4270     4263       -7     
+ Partials      800      797       -3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ed10a0...31ca15c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 19, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-17 18:26:01

Comparing candidate commit 31ca15c in PR branch dubloom/process-tags-crashtracking with baseline commit 7ed10a0 in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 189 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-1471.117ns; -528.883ns] or [-12.058%; -4.335%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+36.056ns; +113.344ns] or [+3.008%; +9.456%]

scenario:TraceSerializationBench/benchSerializeTrace-opcache

  • 🟩 execution_time [-15.821µs; -7.479µs] or [-4.546%; -2.149%]

Base automatically changed from dubloom/process-tags to master January 19, 2026 12:07
@dubloom dubloom marked this pull request as ready for review January 19, 2026 12:09
@dubloom dubloom requested a review from a team as a code owner January 19, 2026 12:09
@dubloom dubloom changed the title Adds process_tags to live crashtracking tags Adds process_tags to crashtracking tags Feb 12, 2026
@dubloom dubloom merged commit a9caaa0 into master Feb 17, 2026
2070 checks passed
@dubloom dubloom deleted the dubloom/process-tags-crashtracking branch February 17, 2026 18:35
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants