Skip to content

Missing enums, classes, methods and funcs#292

Open
ANTINICKNAMES wants to merge 9 commits intoDK22Pac:masterfrom
ANTINICKNAMES:master
Open

Missing enums, classes, methods and funcs#292
ANTINICKNAMES wants to merge 9 commits intoDK22Pac:masterfrom
ANTINICKNAMES:master

Conversation

@ANTINICKNAMES
Copy link
Contributor

  1. Added missing Animation Enums
  2. Added Initialise method in CAEPedSpeechAudioEntity class.
  3. Added Load/Save funcs for CAERadioTrackManager, CGameLogic, CGarages, CPathFind, CPlayerInfo.
  4. Added CTagManager, CStuntJumpManager, CShopping, CPedType and SurfaceInfos_c classes. (untested)
  5. Added missing methods and classes for CPostEffects. (untested)
  6. Added data members for CTaskSimpleHoldEntity.
  7. Added missing CLines class.
  8. Fixed ScriptParams array in CTheScripts
  9. Added new Events: renderMirror, renderScene, renderEffects, drawFontsEvent

ANTINICKNAMES and others added 4 commits March 6, 2026 10:34
1. Added missing Animation Enums
2. Added Initialise method in CAEPedSpeechAudioEntity class.
3. Added Load/Save funcs for CAERadioTrackManager, CGameLogic, CGarages, CPathFind, CPlayerInfo.
4. Added CTagManager, CStuntJumpManager, CShopping, CPedType and SurfaceInfos_c classes.
5. Added missing methods and classes for CPostEffects.
6. Added data members for CTaskSimpleHoldEntity.
@ANTINICKNAMES
Copy link
Contributor Author

I know it's a (bit) messy... Let me know if something wrong.

#pragma once

// original name. prev name eAnimID
enum AnimationIds : int32_t {
Copy link
Contributor

@MiranDMC MiranDMC Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why plural form? It was "AnimationId" in reversed project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts with typedef int AnimationId; from CTaskComplexPlayHandSignalAnim.

Copy link
Contributor

@MiranDMC MiranDMC Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

};

/*
// [GROUP] i = 0 | GroupName : default | Group ID: 0 | Total Animations: 191
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is ton of commented out crap?

0x53E83C, H_CALL,
0x53EBA2, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> drawAfterFadeEvent;

static inline CdeclEvent <AddressList<0x53EBB1, H_CALL>, PRIORITY_AFTER, ArgPickNone, void()> drawFontsEvent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add same events for III and VC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, except Mirror stuff cuz there's no mirrors in GTA3/VC.

#include "meta/meta.CTheScripts.h"

SUPPORTED_10US extern int* ScriptParams; // 32
SUPPORTED_10US extern int (&ScriptParams)[10]; // 32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment says 32 and you are making it 10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, just 10.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next known address is jumptableLabels at 00A43CF8, which gives 128 bytes, divided by four: 32.
https://github.com/gta-reversed/gta-reversed/blob/master/source/game_sa/Scripts/RunningScript.h#L81

struct imf {
float screenZ;
float recipCameraZ;
RwRaster* RasterDrawBuffer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not aligned as everything else?

float m_fHeadingChangeRate;
int field_564;
int field_568;
CEntity* m_standingOnEntity;
Copy link
Contributor

@MiranDMC MiranDMC Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done in #289

ANIM_ID_CAR_DOORLOCKED_RHS = 390,

//
// Add above
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this comment mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants