fix(linter): harden traverseSchema (cycle-safe traversal, unambiguous paths)#833
Open
Mehrn0ush wants to merge 1 commit intoCycloneDX:2.0-dev-threatmodelingfrom
Conversation
… paths) Signed-off-by: Mehrn0ush <mehrnoush.vaseghi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens
traverseSchemaintools/src/main/js/linter/index.js:safePathJoin:$["a.b"])maxDepth, defaultInfinity) with anonDepthLimithook.onCycle/onDangerousKeycallbacks andDANGEROUS_PATH_KEYSexport (defense-in-depth for any future path consumers).Why
Maximum call stack size exceeded) when schemas are circular in-memory (programmatic construction, loader back-references, alias graphs)..or other non-identifier characters.Compatibility / Behavior
traverseSchema(schema, visitor)); additional parameters are optional.maxDepthdefaults toInfinity(no truncation unless explicitly configured).Security notes
Object.entriesreturns only own enumerable properties;traverseSchemadoes not traverse inherited properties and does not mutate objects.issue.pathis used for reporting/CLI output only; no path-based setters are used.DANGEROUS_PATH_KEYS/onDangerousKeyare provided as defense-in-depth for any future consumers.Testing
cd tools/src/test/js && npm install && npm testnode --check tools/src/main/js/linter/index.jsnode tools/src/main/js/linter/cli.js -i enum-value-formatting schema/2.0/cyclonedx-2.0.schema.jsonCloses #832