Added .aminmax() method documentation#8247
Added .aminmax() method documentation#8247abdultalha0862 wants to merge 3 commits intoCodecademy:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Codecademy Docs term entry for PyTorch’s .aminmax() tensor operation, addressing issue #8238 by documenting what the operation does and providing usage guidance.
Changes:
- Introduces a new term page for
.aminmax()under PyTorch tensor operations. - Documents the method’s purpose, parameters, return value, and includes a runnable example with expected output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ``` | ||
|
|
||
| - `input` (Tensor): The input tensor to find the minimum and maximum values from. | ||
| - `dim` (int, optional): The dimension along which to compute the values. If `None`, computes over the entire tensor. |
There was a problem hiding this comment.
dim is documented as int, but in PyTorch reductions this argument commonly supports a tuple of dimensions as well (i.e., reducing over multiple axes). Consider updating this parameter description to indicate it can be an int or a tuple of ints ("dimension(s)") so readers don't miss multi-dim usage.
| - `dim` (int, optional): The dimension along which to compute the values. If `None`, computes over the entire tensor. | |
| - `dim` (int or tuple of ints, optional): The dimension(s) along which to compute the values. If `None`, computes over the entire tensor. |
abdultalha0862
force-pushed
the
add-aminmax-function
branch
from
8980501 to
03d9cd8
Compare
Update .aminmax() method
abdultalha0862
force-pushed
the
add-aminmax-function
branch
from
03d9cd8 to
37931c3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@mamtawardhani I have solved the issue #8238 Please let me if there are any changes Ready for Review |
Clarified the efficiency of the .aminmax() method by stating it performs both reductions in a single pass through the data.
mamtawardhani
left a comment
mamtawardhani
left a comment
There was a problem hiding this comment.
The PR looks good for a second round of review! 🚀
mamtawardhani
added
python
2 participants
Description
Added
.aminmax()method in PyTorch tensor operations.Issue Solved
#8238
Type of Change
Checklist
mainbranch.Issues Solvedsection.