Sheffield | ITP-Jan-26| Mona_Eltantawy | Sprint 3 | Sprint 3/ implement and werite#1280
Open
Mona-Eltantawy wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
Sheffield | ITP-Jan-26| Mona_Eltantawy | Sprint 3 | Sprint 3/ implement and werite#1280Mona-Eltantawy wants to merge 4 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Mona-Eltantawy
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Mona-Eltantawy
changed the title
Mona-Eltantawy
added
the
Needs Review
cjyuan
reviewed
Mar 29, 2026
Comment on lines
+21
to
+22
| else if (angle===90) { | ||
| return 'Right angle'; |
Contributor
There was a problem hiding this comment.
Spacing around the operator is not consistent.
If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.
If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:
- Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
- Edit
settings.jsonand set Prettier as the default formatter for JS.
See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode
Comment on lines
+14
to
+16
| if( numerator < denominator) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
Can you lookup if -1/-2, 1/-2, -1/2, 1/0, -1/0 are considered proper fractions, and then update
your implementation and tests accordingly?
Comment on lines
+40
to
+42
| if (rank >= "2" && rank <= "10") { | ||
| return Number(rank); | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think this function can pass all the tests you have prepared.
Comment on lines
+43
to
+48
| test (`should return "Invalid angle" when (angle <= 0 or angle > 360)` ,() => { | ||
|
|
||
| expect(getAngleType(0)).toEqual("Invalid angle"); | ||
| expect(getAngleType(400)).toEqual("Invalid angle"); | ||
| expect(getAngleType(-10)).toEqual("Invalid angle"); | ||
| }); No newline at end of file |
Contributor
There was a problem hiding this comment.
Could consider testing both boundary cases.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist