London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| alarm clock#1057
Open
alexandru-pocovnicu wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| alarm clock#1057alexandru-pocovnicu wants to merge 7 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
alexandru-pocovnicu
added
the
Needs Review
cjyuan
reviewed
Mar 30, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code works fine if a user only clicks the "Set Alarm" button once.
However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.
Can you fix the issue?
Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.
Consider introducing a dedicated reset function to return the app to a clean initial state to help ensure consistency.
| function setAlarm() { | ||
| const alarmSetEl = document.getElementById("alarmSet"); | ||
| const timeRemainingEl = document.getElementById("timeRemaining"); | ||
| let totalSeconds = +alarmSetEl.value; |
Contributor
There was a problem hiding this comment.
Some unusual input values can make your app behave abnormally. Can you add code to sanitise them?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
implemented an alarm clock that counts down from the input value