Conversation
sam-schu
requested changes
Feb 18, 2026
| "compilerOptions": { | ||
| "esModuleInterop": true | ||
| "esModuleInterop": true, | ||
| "strict": true |
Collaborator
There was a problem hiding this comment.
very epic and awesome line of code right here that I am very excited for !!
Collaborator
There was a problem hiding this comment.
I don't see any package.json changes?
Collaborator
There was a problem hiding this comment.
@Juwang110 How come we have changes to the yarn lock but not the package.json?
Author
There was a problem hiding this comment.
Sorry, not sure, will look into that
sam-schu
requested changes
Feb 21, 2026
dburkhart07
requested changes
Feb 22, 2026
apps/backend/src/donationItems/dtos/create-donation-items.dto.ts
Outdated
Show resolved
Hide resolved
|
Gonna wait on Sam's approval before I do a final review I think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-131 and
https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-138
📝 Description
This PR enables typescript strict mode in the backend which enables the compiler to be a lot more picky and strict with types, null and undefined checks, etc. The PR includes changes to make our backend adhere with all the rules that strict mode enforces. This involved work making entity fields optional or required, and also handling null/undefined errors and return values.
✔️ Verification
I made sure all the backend tests pass and npx nx serve backend properly runs without error.
🏕️ (Optional) Future Work / Notes
N/A