Skip to content

update delete grant so it deletes notifs too#391

Open
camila-carrillo wants to merge 2 commits intomainfrom
382-dev---update-delete-grant-so-it-notifications-as-well
Open

update delete grant so it deletes notifs too#391
camila-carrillo wants to merge 2 commits intomainfrom
382-dev---update-delete-grant-so-it-notifications-as-well

Conversation

@camila-carrillo
Copy link
Copy Markdown
Contributor

ℹ️ Issue

Closes #382

📝 Description

Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.

Makes sure grant notifications are created and deleted when the corresponding grant is created/deleted. It is important because the two entities should be in sync with each other.

Briefly list the changes made to the code:

  1. Added deleteGrantNotifications()
  2. Called above in deleteGrantById()
  3. Fixed a bug that was causing notifications to overwrite each other. Notifications now follow structure ${grantId}-app-${days} and ${grantId}-report-${index}-${days}.
  4. uncommented creategrantnotifications call in addgrant

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Created a grant with an application deadline and at least one report deadline in the near past, opened notification dropdown and made sure correct notifications popped up. Deleted the grant. Ensured notifications also correctly deleted from the dropdown and dynamodb table.

Provide screenshots of any new components, styling changes, or pages.
n/a

Test Changes

If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

@camila-carrillo camila-carrillo linked an issue Apr 3, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV - Update Delete Grant so it notifications as well

1 participant