Skip to content

Comments

301 dev set up s3 bucket and profile pics#323

Merged
prooflesben merged 10 commits intomainfrom
301-dev---set-up-s3-bucket-and-profile-pics
Feb 24, 2026
Merged

301 dev set up s3 bucket and profile pics#323
prooflesben merged 10 commits intomainfrom
301-dev---set-up-s3-bucket-and-profile-pics

Conversation

@prooflesben
Copy link
Collaborator

ℹ️ Issue

Closes

📝 Description

  1. Set up s3 bucket connection using amazon sdk v2(need to migrate to v3)
  2. Created upload profile pic route to upload profile pictures

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.

Test Changes

Manual testing

🏕️ (Optional) Future Work / Notes

Auto logout this can be done in auth context

@prooflesben prooflesben linked an issue Feb 18, 2026 that may be closed by this pull request
Copy link
Collaborator

@lyannne lyannne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in ur pr that you said auto logging out can be done via auth? can you clarify what that means? also on that note, I saw in auth, the updateProfile method was a post — should that be a patch instead?

Copy link
Contributor

@camila-carrillo camila-carrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only things i noticed were the logging i commented on and also what lyanne mentioned with the post/patch. besides that lgtm

@prooflesben prooflesben merged commit 77c8b1b into main Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV - Set up S3 bucket and Profile pics

3 participants