Skip to content

[ENG-10697] Update unique locators for search page#937

Open
nsemets wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-6from
nsemets:feat/ENG-10697
Open

[ENG-10697] Update unique locators for search page#937
nsemets wants to merge 2 commits intoCenterForOpenScience:feature/pbs-26-6from
nsemets:feat/ENG-10697

Conversation

@nsemets
Copy link
Copy Markdown
Collaborator

@nsemets nsemets commented Apr 6, 2026

Purpose

Summary of Changes

  1. Added data attributes for search page.

Screenshot(s)

image image

@nsemets nsemets changed the title [ENG-10698] Update unique locators for Registration overview page [ENG-10697] Update unique locators for search page Apr 6, 2026
@nsemets nsemets requested a review from brianjgeiger April 6, 2026 14:33
Copy link
Copy Markdown
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need an outer selector for the cards to allow QE to distinguish between multiple cards of the same type on the same page. Something like data-test-registration-card=<guid> which would allow them to select a specific card if they know the guid, then they could pick the individual card parts from there. Does that make sense?

@nsemets nsemets closed this Apr 6, 2026
@nsemets nsemets reopened this Apr 6, 2026
@nsemets
Copy link
Copy Markdown
Collaborator Author

nsemets commented Apr 6, 2026

@brianjgeiger I can add this at a higher level, where it uses the resource card osf-resource-card. Is it ok?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants