[backends] Add comprehensive test suite for VideoStreamMoviePy#512
[backends] Add comprehensive test suite for VideoStreamMoviePy#512chyang-nycu wants to merge 4 commits intoBreakthrough:mainfrom
Conversation
|
I like where this is going in concept, but would prefer to have this abstracted over the backend itself similar to the existing The tests in that file are run across all backends to ensure consistency, and there might be some overlap. |
Breakthrough
force-pushed
the
main
branch
2 times, most recently
from
edb5d06 to
8f94e04
Compare
Breakthrough
force-pushed
the
main
branch
6 times, most recently
from
b3c542a to
98f4be6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Attempt invalid seek | ||
| try: | ||
| video.seek(999999) | ||
| except SeekError: |
Check notice
Code scanning / CodeQL
Empty except Note test
There was a problem hiding this comment.
@chyang-nycu can we use Pytest to ensure this is raised?
https://docs.pytest.org/en/7.1.x/how-to/assert.html
|
@chyang-nycu are you still open to merging this? It just needs to pass |
| # Attempt invalid seek | ||
| try: | ||
| video.seek(999999) | ||
| except SeekError: |
There was a problem hiding this comment.
@chyang-nycu can we use Pytest to ensure this is raised?
https://docs.pytest.org/en/7.1.x/how-to/assert.html
3 participants
Uh oh!
There was an error while loading. Please reload this page.