add additional debug message about flushing databases#187
Open
philippem wants to merge 1 commit intoBlockstream:new-indexfrom
Open
add additional debug message about flushing databases#187philippem wants to merge 1 commit intoBlockstream:new-indexfrom
philippem wants to merge 1 commit intoBlockstream:new-indexfrom
Conversation
philippem
force-pushed
the
trivial-log
branch
2 times, most recently
from
c508f5b to
27bb203
Compare
philippem
force-pushed
the
trivial-log
branch
from
27bb203 to
9a4ef6c
Compare
| debug!("flushing history_db disk"); | ||
| self.store.history_db.flush(); | ||
| debug!("flushing history_db complete"); | ||
|
|
There was a problem hiding this comment.
I wonder, do we need the cache db flushed?
Collaborator
Author
There was a problem hiding this comment.
at this point in the sync the db is empty. having the flush there would be no op, probably no harm.
|
lgtm |
RCasatta
reviewed
Mar 5, 2026
| debug!("flushing to disk"); | ||
| debug!("flushing txstore_db disk"); | ||
| self.store.txstore_db.flush(); | ||
| debug!("flushing txstore_db complete"); |
Collaborator
There was a problem hiding this comment.
I would have added a time elapsed at this point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.