feat: use wasm-dot parser in verifyTransaction for tdot#8322
Merged
Conversation
2abc269 to
5f26ae1
Compare
8f6a2bf to
03d9808
Compare
Both wasm-dot and legacy now produce signing payload format for unsigned transactions, so the format detection hack (compactByte, versionByte, isStandardFormat) is no longer needed. Use chain === 'tdot' as the gate for the wasm path instead. Update WASM test fixtures from old standard extrinsic format to signing payload format to match the new wasm-dot output. BTC-3161 TICKET: BTC-3161
03d9808 to
6060d22
Compare
davidkaplanbitgo
approved these changes
Mar 19, 2026
margueriteblair
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both wasm-dot and legacy now produce signing payload format for unsigned
transactions, so the format detection hack (compactByte, versionByte,
isStandardFormat) is no longer needed. Use chain === 'tdot' as the gate
for the wasm path instead.
Update WASM test fixtures from old standard extrinsic format to signing
payload format to match the new wasm-dot output.
BTC-3161
TICKET: BTC-3161