Open
Conversation
Marzooqa
force-pushed
the
feat/eddsa-dkg-class
branch
from
73943f4 to
198f1ea
Compare
mrdanish26
reviewed
Mar 13, 2026
Marzooqa
force-pushed
the
feat/eddsa-dkg-class
branch
from
198f1ea to
79687b9
Compare
Contributor
|
Why are we not using @bitgo/wasm-mps? |
Marzooqa
force-pushed
the
feat/eddsa-dkg-class
branch
from
79687b9 to
7e545c5
Compare
- Add EdDSA DKG MPS implementation with core types and utilities - Implement distributed key generation for EdDSA signatures - Add type definitions for DKG session Ticket: WP-8197
Marzooqa
force-pushed
the
feat/eddsa-dkg-class
branch
from
7e545c5 to
bf6ac45
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mrdanish26
reviewed
Mar 19, 2026
| } | ||
|
|
||
| const seed = dkgSeed ?? crypto.randomBytes(32); | ||
| const result = ed25519_dkg_round0_process(this.partyIdx, this.decryptionKey!, this.otherPubKeys!, seed); |
Contributor
There was a problem hiding this comment.
WASM calls can throw unexpected errors. Should we wrap in try-catch?
| } | ||
|
|
||
| export function deserializeMessage(msg: SerializedMessage): DeserializedMessage { | ||
| return { from: msg.from, payload: new Uint8Array(Buffer.from(msg.payload, 'base64')) }; |
Contributor
There was a problem hiding this comment.
Buffer.from() already returns a Buffer which is a Uint8Array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds EdDSA multi-party schnorr Distributed Key Generation (DKG) support to the BitGoJS SDK, specifically within the sdk-lib-mpc module.
It introduces new dependencies for Silence Laboratories' EdDSA WASM libraries, implements the EdDSA DKG protocol for multi-party threshold key generation, and provides supporting types and utility functions.
The PR also includes comprehensive unit tests that cover key share generation, deterministic and random seeding, and utility behaviors.
Ticket: WP-8197