-
Notifications
You must be signed in to change notification settings - Fork 8
Hamming distance #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hamming distance #15
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://biojulia.dev/BiojuliaDocs/previews/PR15/ |
|
@kescobo Please let me know if the changes I implemented look good and if I can merge in! |
kescobo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this still needs semantic line breaks (sembr.org). You can ask an LLM to suggest if you're not sure, but it's not a hard-and fast rule, just shooting for shorter lines that are more-or-less complete clauses. It makes the diffs much nicer if future edits are made
docs/src/rosalind/06-hamm.md
Outdated
|
|
||
| ### For Loop | ||
|
|
||
| Another way we can approach this would be to use the for-loop. This method will be a bit slower. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily slower - actually this one might be a good candidate for a benchmarking run at the end.
Julia can often optimize for-loops like this, which is one of the things that makes it so powerful. You get SIMD from the count version, but you can also potentially make the for-loop parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added benchmarking! The for-loop was a bit slower, but not suuuper slow! Cool!
Co-authored-by: Kevin Bonham <[email protected]>
Co-authored-by: Kevin Bonham <[email protected]>
|
Semantic line breaks have been added, as well as some benchmarking. I did a last minute check for typos. Hopefully this tutorial will be ready for deployment after a final review! |
|
I'm going to try pinning a different version of Documenter Vitepress due to an error with MathJax (related to the update that they made in v3.0. I'm happy to use a different solution, but thought this would be most straightforward for now. Deployment error here: https://github.com/BioJulia/BioTutorials/actions/runs/21789778782/job/62867068788 |
|
The deployment seems to have worked on Github Actions. However, I'm now getting a 404 error on the site! |
Tutorial for Hamming Distance problem
I added two different ways to solve the problem: with a function I wrote, as well as a function in the BioAlignments package. Please let me know if there's anything else that would be good to add to this tutorial!