Skip to content

logging missing attributes for calnet validatation, loggin uid instea…#33

Merged
davezuckerman merged 1 commit intomainfrom
AP-610-calnet-log-attributes
Mar 5, 2026
Merged

logging missing attributes for calnet validatation, loggin uid instea…#33
davezuckerman merged 1 commit intomainfrom
AP-610-calnet-log-attributes

Conversation

@davezuckerman
Copy link
Contributor

For missing calnet attributes we we're raising errors. This will log them instead. As well we won't log displayName and will log UID instead.

Copy link
Contributor

@yzhoubk yzhoubk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks

Copy link
Member

@anarchivist anarchivist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+. looks great, thanks!

@davezuckerman davezuckerman marked this pull request as ready for review March 5, 2026 22:21
@davezuckerman davezuckerman merged commit f26f811 into main Mar 5, 2026
5 checks passed
@davezuckerman davezuckerman deleted the AP-610-calnet-log-attributes branch March 5, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants