Conversation
bgavrilMS
reviewed
Dec 9, 2024
bgavrilMS
approved these changes
Dec 17, 2024
neha-bhargava
approved these changes
Dec 18, 2024
neha-bhargava
left a comment
There was a problem hiding this comment.
Approve with comment to add another test for common as tenant
442f85c to
b1b5e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature request #767 calls for support for dSTS authority.
The understanding was that:
oidc_authority(i.e. no Instance Discovery, no "/v2.0" hardcoded string within its endpoint), so, it should just work if the caller would choose to put a dSTS url into theoidc_authorityparameter, even if we might not advertise so.authorityparameter, so that MSAL's downstream ecosystem can support dSTS transparently without needing to pick up theoidc_authorityparameter first.Therefore, this PR attempts an implementation that simply converts the
authority=https://foo.bar.example.com/dstsv2/placeholderintooidc_authority=https://foo.bar.example.com/dstsv2/placeholderunder the hood, and then all the oidc authority behaviors will automatically kick in.With regard to the tests:
authority=https://foo.bar.example.com/dstsv2/placeholder(therefore testing point B above)#2doesn't apply because MSAL Python does not supportWithTenant(...). But I'm open to add more test cases if desirable.This will resolve #767
P.S.: The test automation is currently failing due to other reason. They will be fixed soon outside of this PR. This situation does not prevent this PR from being reviewed.Test automation works again now.