Fix TableClient.list_entities(query_filter=...) leaking kwarg to tran…#46137
Open
ahmedtaha100 wants to merge 1 commit intoAzure:mainfrom
Open
Fix TableClient.list_entities(query_filter=...) leaking kwarg to tran…#46137ahmedtaha100 wants to merge 1 commit intoAzure:mainfrom
ahmedtaha100 wants to merge 1 commit intoAzure:mainfrom
Conversation
…sport Fixes Azure#46014. list_entities() was forwarding all **kwargs (including query_filter and parameters) into the generated operation's partial, causing them to leak to the aiohttp transport layer as unexpected kwargs. Now consumes query_filter/parameters before building the partial and passes the substituted filter value to the pager, matching query_entities() behavior. Fix applied to both sync and async clients.
|
Thank you for your contribution @ahmedtaha100! We will review the pull request and get back to you soon. |
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #46014
When calling list_entities(query_filter=...), the query_filter and parameters kwargs were being forwarded straight through **kwargs into functools.partial(self._client.table.query_entities, **kwargs). This meant they leaked all the way down to the aiohttp transport layer, which raised TypeError.
The fix pops query_filter and parameters from kwargs before building the partial, runs parameter substitution if needed, and passes the result as filter= to the pager -- same pattern that query_entities() already uses. Applied to both sync and async clients since both had the same issue.
Changes
Test results
@YalinLi0312 @klaaslanghout I’d appreciate a review when you have a chance. This fixes the
list_entities(query_filter=...)kwarg leak inazure-data-tablesand adds regression coverage.