Skip to content

Update deprecation_process.md with version_client.txt instructions#48426

Merged
XiaofeiCao merged 5 commits intoAzure:mainfrom
XiaofeiCao:fix/deprecation-process-version-client
Mar 17, 2026
Merged

Update deprecation_process.md with version_client.txt instructions#48426
XiaofeiCao merged 5 commits intoAzure:mainfrom
XiaofeiCao:fix/deprecation-process-version-client

Conversation

@XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Mar 16, 2026

Add a step to update eng/versioning/version_client.txt when the release version differs from the current-version during package deprecation.

Add a step to update eng/versioning/version_client.txt when the release
version differs from the current-version during package deprecation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@XiaofeiCao XiaofeiCao marked this pull request as ready for review March 16, 2026 07:04
@XiaofeiCao XiaofeiCao requested a review from a team as a code owner March 16, 2026 07:04
Copilot AI review requested due to automatic review settings March 16, 2026 07:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Java package deprecation process documentation to include a missing step for updating eng/versioning/version_client.txt when the intended release version doesn’t match the current-version recorded there.

Changes:

  • Document updating eng/versioning/version_client.txt (current-version / third field) to the version being released, with an example diff.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Java package deprecation process documentation to remind package owners to align eng/versioning/version_client.txt with the version being released when performing a deprecation final release.

Changes:

  • Adds an explicit Step 1 checklist item to update eng/versioning/version_client.txt when the intended release version differs from the tracked current-version.
  • Includes a concrete diff-style example showing how to update the third field (current-version).

You can also share your feedback on Copilot code review. Take the survey.

- Introduce repo-level section to distinguish from package-level files
- Replace ambiguous 'update it' with explicit 'set the current-version'
- Remove redundant phrasing

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Java package deprecation process documentation to include a repo-level versioning step, ensuring version_client.txt reflects the actual release version during a deprecation release.

Changes:

  • Adds guidance to update eng/versioning/version_client.txt when current-version differs from the release version.
  • Includes a small diff example showing the expected current-version update.

You can also share your feedback on Copilot code review. Take the survey.

XiaofeiCao and others added 2 commits March 16, 2026 17:19
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@XiaofeiCao XiaofeiCao merged commit b1b8672 into Azure:main Mar 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants