Fix various warnings#2002
Open
darbyjohnston wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
Fix various warnings#2002darbyjohnston wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
darbyjohnston wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 181 181
Lines 12783 12784 +1
Branches 1206 1206
=======================================
+ Hits 10885 10886 +1
Misses 1715 1715
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1408
This PR fixes various warnings in the OTIO build:
setuptools warnings(these were actually necessary forcheck-manifest)We still have a couple of C++ warnings about functions that have been deprecated, these should probably stay on to remind us to remove them at some point.
The setuptools warnings:
Seem to be coming from excluding files in the manifest that were not included in the first place, but it would be good for someone with more Python knowledge to double check this. There are still a couple of warnings about temporary files (*.pyc, .DS_Store, etc.) that seem OK to leave in.