Make batched use ustringhash_pod and make batched compile in Windows#1831
Open
johnfea wants to merge 5 commits intoAcademySoftwareFoundation:mainfrom
Open
Make batched use ustringhash_pod and make batched compile in Windows#1831johnfea wants to merge 5 commits intoAcademySoftwareFoundation:mainfrom
johnfea wants to merge 5 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EDIT:
Make batched and non-batched internally use the same string representation for reasons discussed below.
Tests
New test cases aren't necessarily required.
This PR would fix new failing test case in #1832.
Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.