int: Remove deprecated std::codecvt from strutil.cpp internals#5107
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
int: Remove deprecated std::codecvt from strutil.cpp internals#5107lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
For the sake of Windows' need for wstring filenames, we do some utf8<->utf16 conversion in strutil.cpp. That has always used the std::codecvt set of functions, but they have been deprecated beginning in C++17 and will be removed entirely in C++26, so their days are numbered and we already have to suppress warnings to get the compiler to shut up about it. Assisted-by: Claude Code / Opus 4.6 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the sake of Windows' need for wstring filenames, we do some utf8<->utf16 conversion in strutil.cpp. That has always used the std::codecvt set of functions, but they have been deprecated beginning in C++17 and will be removed entirely in C++26, so their days are numbered and we already have to suppress warnings to get the compiler to shut up about it.
Assisted-by: Claude Code / Opus 4.6