fix: catch exceptions in print-uncaught-messages destructor#5103
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
fix: catch exceptions in print-uncaught-messages destructor#5103lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Fixes 5063 In that issue, it was reported that the printing of any unretrieved error messages upon destruction of an ImageBuf could itself have an exception (including if it, for some reason, could not correctly fwrite the output). And if that is the case, it could terminate the app. So for safety, this patch encloses this particular print statement in a try/catch. And also found another in ErrorHolder in the internals of Strutil, which is used for "global" errors issued to OIIO::errorfmt(). Assisted-by: Claude Code / Opus 4.6 I did the fix in ImageBuf, then Claude found the other spot in ErrorHolder that also needed the fix. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5063
In that issue, it was reported that the printing of any unretrieved error messages upon destruction of an ImageBuf could itself have an exception (including if it, for some reason, could not correctly fwrite the output). And if that is the case, it could terminate the app.
So for safety, this patch encloses this particular print statement in a try/catch. And also found another in ErrorHolder in the internals of Strutil, which is used for "global" errors issued to OIIO::errorfmt().
Assisted-by: Claude Code / Opus 4.6
I did the fix in ImageBuf, then Claude found the other spot in ErrorHolder that also needed the fix.