feat: add block-editor app with BlockNote and Tiptap UI components#7
Open
Nihallllll wants to merge 1 commit intoAOSSIE-Org:mainfrom
Open
feat: add block-editor app with BlockNote and Tiptap UI components#7Nihallllll wants to merge 1 commit intoAOSSIE-Org:mainfrom
Nihallllll wants to merge 1 commit intoAOSSIE-Org:mainfrom
Conversation
|
Important Review skippedToo many files! This PR contains 154 files, which is 4 over the limit of 150. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (154)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
no-issue-linked
frontend
javascript
size/XL
first-time-contributor
labels
|
Thanks for the detailed block editor implementation — the UI and TipTap integration look very comprehensive. One architectural question I had while reading the code: SmartNotes is designed around a filesystem vault with Markdown notes, but the current editor path initializes internal block structures and doesn’t yet show a clear Markdown serialization pipeline. Do we expect Markdown to remain the canonical storage format, or will the editor JSON become the primary persisted representation? It might help to define a small adapter boundary early (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
Added a notion-like editor
for the smart notes project
Screenshots/Recordings:
Screen.Recording.2026-03-03.095810.mp4