Skip to content

Remove unnecessary pylint disables. #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 10, 2026
Merged

Remove unnecessary pylint disables. #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pathwaysutils/profiling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def _start_pathways_trace_from_profile_request(
try:
_, result_future = _profile_state.executable.call()
result_future.result()
except Exception: # pylint: disable=broad-except
except Exception:
_logger.exception("Failed to start trace")
_profile_state.reset()
raise
Expand Down Expand Up @@ -191,7 +191,7 @@ class ProfilingConfig:
repository_path: str

@app.post("/profiling")
async def profiling(pc: ProfilingConfig) -> dict[str, str]: # pylint: disable=unused-variable
async def profiling(pc: ProfilingConfig) -> dict[str, str]:
_logger.debug("Capturing profiling data for %s ms", pc.duration_ms)
_logger.debug("Writing profiling data to %s", pc.repository_path)
await asyncio.to_thread(jax.profiler.start_trace, pc.repository_path)
Expand Down Expand Up @@ -275,7 +275,7 @@ def start_trace_patch(
log_dir,
create_perfetto_link: bool = False,
create_perfetto_trace: bool = False,
profiler_options: jax.profiler.ProfileOptions | None = None, # pylint: disable=unused-argument
profiler_options: jax.profiler.ProfileOptions | None = None,
) -> None:
_logger.debug("jax.profile.start_trace patched with pathways' start_trace")
start_trace(
Expand Down
Loading