From 73d61b058ebf28c041ff1939f7410ed8fd43d08d Mon Sep 17 00:00:00 2001 From: Katie McFaul Date: Mon, 23 Mar 2026 11:05:01 -0400 Subject: [PATCH 1/2] fix(Popper): add null & connected checks for document --- .../popper-core/dom-utils/getDocumentElement.ts | 2 +- .../Popper/thirdparty/react-popper/usePopper.ts | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/react-core/src/helpers/Popper/thirdparty/popper-core/dom-utils/getDocumentElement.ts b/packages/react-core/src/helpers/Popper/thirdparty/popper-core/dom-utils/getDocumentElement.ts index 2489986c00f..76faa40bc2d 100644 --- a/packages/react-core/src/helpers/Popper/thirdparty/popper-core/dom-utils/getDocumentElement.ts +++ b/packages/react-core/src/helpers/Popper/thirdparty/popper-core/dom-utils/getDocumentElement.ts @@ -7,5 +7,5 @@ import { Window } from '../types'; */ export default function getDocumentElement(element: Element | Window): HTMLElement { // $FlowFixMe: assume body is always available - return (isElement(element) ? element.ownerDocument : element.document).documentElement; + return ((isElement(element) ? element.ownerDocument : element.document) || window.document).documentElement; } diff --git a/packages/react-core/src/helpers/Popper/thirdparty/react-popper/usePopper.ts b/packages/react-core/src/helpers/Popper/thirdparty/react-popper/usePopper.ts index 97b99893ae4..f105144b9d9 100644 --- a/packages/react-core/src/helpers/Popper/thirdparty/react-popper/usePopper.ts +++ b/packages/react-core/src/helpers/Popper/thirdparty/react-popper/usePopper.ts @@ -35,6 +35,17 @@ type State = { const EMPTY_MODIFIERS: any = []; +function isReferenceConnected(reference: Element | VirtualElement): boolean { + if (reference instanceof Element) { + return reference.isConnected; + } + const { contextElement } = reference; + if (contextElement instanceof Element) { + return contextElement.isConnected; + } + return true; +} + export const usePopper = ( referenceElement: (Element | VirtualElement) | null | undefined, popperElement: HTMLElement | null | undefined, @@ -114,6 +125,10 @@ export const usePopper = ( return; } + if (!isReferenceConnected(referenceElement) || !popperElement.isConnected) { + return; + } + const createPopper = options.createPopper || defaultCreatePopper; const popperInstance = createPopper(referenceElement, popperElement, popperOptions); From 0d33466d427eb9d38d9a12a81ade982f48ec2b0b Mon Sep 17 00:00:00 2001 From: Donald Labaj Date: Mon, 23 Mar 2026 12:03:55 -0400 Subject: [PATCH 2/2] chore: sync yarn.lock with registry metadata for react-router Yarn hardened mode on public PRs rejects a lockfile that lists stale dependencies for react-router@7.13.0. Refresh the lockfile so `yarn install --immutable` succeeds in CI. Made-with: Cursor --- yarn.lock | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/yarn.lock b/yarn.lock index b93ab9c0519..9107a6c2def 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5477,13 +5477,6 @@ __metadata: languageName: node linkType: hard -"@types/cookie@npm:^0.6.0": - version: 0.6.0 - resolution: "@types/cookie@npm:0.6.0" - checksum: 10c0/5b326bd0188120fb32c0be086b141b1481fec9941b76ad537f9110e10d61ee2636beac145463319c71e4be67a17e85b81ca9e13ceb6e3bb63b93d16824d6c149 - languageName: node - linkType: hard - "@types/d3-array@npm:^3.0.3": version: 3.2.1 resolution: "@types/d3-array@npm:3.2.1" @@ -19339,10 +19332,8 @@ __metadata: version: 7.13.0 resolution: "react-router@npm:7.13.0" dependencies: - "@types/cookie": "npm:^0.6.0" cookie: "npm:^1.0.1" set-cookie-parser: "npm:^2.6.0" - turbo-stream: "npm:2.4.0" peerDependencies: react: ">=18" react-dom: ">=18" @@ -22550,13 +22541,6 @@ __metadata: languageName: node linkType: hard -"turbo-stream@npm:2.4.0": - version: 2.4.0 - resolution: "turbo-stream@npm:2.4.0" - checksum: 10c0/e68b2569f1f16e6e9633d090c6024b2ae9f0e97bfeacb572451ca3732e120ebbb546f3bc4afc717c46cb57b5aea6104e04ef497f9912eef6a7641e809518e98a - languageName: node - linkType: hard - "tweetnacl@npm:^0.14.3, tweetnacl@npm:~0.14.0": version: 0.14.5 resolution: "tweetnacl@npm:0.14.5"