Skip to content

Fix Slack notification for release notes PRs from forks#24566

Merged
aevesdocker merged 1 commit intodocker:mainfrom
lorenrh:add-rn-notif
Mar 30, 2026
Merged

Fix Slack notification for release notes PRs from forks#24566
aevesdocker merged 1 commit intodocker:mainfrom
lorenrh:add-rn-notif

Conversation

@lorenrh
Copy link
Copy Markdown
Member

@lorenrh lorenrh commented Mar 30, 2026

Description

The Slack notification workflow for Desktop release notes PRs fails when
the PR is opened from a fork because GitHub doesn't expose repository
secrets to pull_request events from forks.

This PR splits the workflow into two:

  1. Release Notes PR Trigger — runs on pull_request, saves PR
    details (URL, title, author) as an artifact. No secrets needed.
  2. Notify Slack on Desktop Release Notes PR — runs on workflow_run
    after the trigger completes, downloads the artifact, and sends the
    Slack notification. Has access to secrets since workflow_run runs in
    the context of the base repository.

Related issues or tickets

Fixes the SlackError: Missing input! A token must be provided error
in the notify-release-notes-pr workflow.

Reviews

  • Technical review

Secrets aren't available to pull_request events from forks. Split into
a trigger workflow that saves PR details as an artifact, and a
notification workflow that downloads the artifact via workflow_run.

Signed-off-by: Lorena Rangel <lorena.rangel@docker.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit c478cd8
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69ca6eb21a9e6f0008dee011
😎 Deploy Preview https://deploy-preview-24566--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aevesdocker aevesdocker merged commit 4210ae6 into docker:main Mar 30, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants