From 0467501f5aff15a6c578cbe88ad0564d73c0bf03 Mon Sep 17 00:00:00 2001 From: Ehab Younes Date: Thu, 26 Mar 2026 22:50:48 +0300 Subject: [PATCH] fix: remove scroll-to-bottom round-trip from chat embed --- src/webviews/chat/chatPanelProvider.ts | 10 ---------- test/unit/webviews/chat/chatPanelProvider.test.ts | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/src/webviews/chat/chatPanelProvider.ts b/src/webviews/chat/chatPanelProvider.ts index 707b6633..3b7f48bd 100644 --- a/src/webviews/chat/chatPanelProvider.ts +++ b/src/webviews/chat/chatPanelProvider.ts @@ -41,10 +41,6 @@ export class ChatPanelProvider : "dark"; } - private sendScrollToBottom(): void { - this.view?.webview.postMessage({ type: "coder:scroll-to-bottom" }); - } - private sendTheme(): void { this.view?.webview.postMessage({ type: "coder:set-theme", @@ -129,7 +125,6 @@ export class ChatPanelProvider break; case "coder:chat-ready": this.sendTheme(); - this.sendScrollToBottom(); break; case "coder:navigate": { const url = msg.payload?.url; @@ -284,11 +279,6 @@ export class ChatPanelProvider }, '${allowedOrigin}'); } - if (data.type === 'coder:scroll-to-bottom') { - iframe.contentWindow.postMessage( - { type: 'coder:scroll-to-bottom' }, '${allowedOrigin}'); - } - if (data.type === 'coder:auth-error') { status.textContent = ''; status.appendChild(document.createTextNode(data.error || 'Authentication failed.')); diff --git a/test/unit/webviews/chat/chatPanelProvider.test.ts b/test/unit/webviews/chat/chatPanelProvider.test.ts index 2b7d94d0..97fa5a88 100644 --- a/test/unit/webviews/chat/chatPanelProvider.test.ts +++ b/test/unit/webviews/chat/chatPanelProvider.test.ts @@ -100,16 +100,6 @@ describe("ChatPanelProvider", () => { }); }); - it("sends scroll-to-bottom on chat-ready", () => { - const { sendFromWebview, postMessage } = createHarness(); - - sendFromWebview({ type: "coder:chat-ready" }); - - expect(findPostedMessage(postMessage, "coder:scroll-to-bottom")).toEqual({ - type: "coder:scroll-to-bottom", - }); - }); - it("sends theme when VS Code theme changes", () => { const { postMessage } = createHarness(); postMessage.mockClear();