Skip to content

chore(js,ui): Don't display impersonation for agents#7933

Merged
tmilewski merged 2 commits intomainfrom
tom/user-4810-remove-impersonationfab-from-ui-when-agent
Feb 26, 2026
Merged

chore(js,ui): Don't display impersonation for agents#7933
tmilewski merged 2 commits intomainfrom
tom/user-4810-remove-impersonationfab-from-ui-when-agent

Conversation

@tmilewski
Copy link
Member

@tmilewski tmilewski commented Feb 25, 2026

Description

Ensures that the Impersonation overlay doesn't display when the actor is an agent.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Sessions now surface agent metadata so agent actors are tracked separately from regular actors.
  • Bug Fixes

    • Impersonation overlay/UI no longer appears when the active actor is an agent.
  • Tests

    • Added tests covering agent actor handling and updated impersonation UI visibility scenarios.

@tmilewski tmilewski self-assigned this Feb 25, 2026
@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 25, 2026 10:50pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: 64f5b88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/clerk-js Minor
@clerk/shared Minor
@clerk/ui Minor
@clerk/chrome-extension Patch
@clerk/expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 568739b and 64f5b88.

📒 Files selected for processing (1)
  • .changeset/cyan-shoes-return.md

📝 Walkthrough

Walkthrough

Adds explicit agent support to session handling and types. Introduces ActClaimType and AgentActClaim in shared types, extends ActClaim with an optional type, and exposes AgentActClaim in SessionResource. Extends the Session class with an agent property populated when actor.type === 'agent'. Updates ImpersonationFab to require actor presence and agent absence to render impersonation UI. Adds tests and fixture updates to cover actor/agent scenarios and a changeset for minor package bumps.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: preventing the impersonation overlay from displaying when the actor is an agent, which is the primary objective across the modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 25, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7933

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7933

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7933

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7933

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7933

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7933

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7933

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7933

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7933

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7933

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@7933

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7933

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7933

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7933

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7933

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7933

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7933

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7933

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7933

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7933

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7933

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7933

commit: 64f5b88

@tmilewski tmilewski merged commit 466d642 into main Feb 26, 2026
67 of 68 checks passed
@tmilewski tmilewski deleted the tom/user-4810-remove-impersonationfab-from-ui-when-agent branch February 26, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants