ARROW-11708: [Rust] fix Rust 2021 linting warnings#9535
Closed
houqp wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-11708: [Rust] fix Rust 2021 linting warnings#9535houqp wants to merge 1 commit intoapache:masterfrom
houqp wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9535 +/- ##
==========================================
- Coverage 82.27% 82.26% -0.01%
==========================================
Files 244 244
Lines 55371 55373 +2
==========================================
+ Hits 45554 45555 +1
- Misses 9817 9818 +1
Continue to review full report at Codecov.
|
alamb
approved these changes
Feb 20, 2021
| impl Into<StructArray> for RecordBatch { | ||
| fn into(self) -> StructArray { | ||
| self.schema | ||
| impl From<RecordBatch> for StructArray { |
Contributor
|
Given this is unlikely to be controversial, I am just merging it in as is |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9535 +/- ##
==========================================
- Coverage 82.27% 82.26% -0.01%
==========================================
Files 244 244
Lines 55371 55373 +2
==========================================
+ Hits 45554 45555 +1
- Misses 9817 9818 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample warning: