Serialization -> Deserialization could have better error messages

[lukeschaefer]

For performance reasons, I'd like to do a number of large operations in memory, rather than interacting with the disk. This succeeds in creating an in-memory db: const db = new Database(':memory:');

However if I want to take an existing db and fully bring it into memory, this fails:

const db = new Database("./snapshot.db");
const buffer = db.serialize();
const inMemoryDb = new Database(buffer);
// Failure occurs on the next line:
inMemoryDb.prepare("SELECT phrase FROM Phrases");

I get SqliteError: unable to open database file. I can confirm the buffer is filled with data that can be written to disk and loaded via the filesystem like usual. But creating a Database out of a buffer seems to always result in a failure.

[Prinzhorn]

Cannot reproduce with the latest better-sqlite3:

import Database from 'better-sqlite3'

const db = new Database('./Chinook_Sqlite.sqlite');
const buffer = db.serialize();
const inMemoryDb = new Database(buffer);
const stmt = inMemoryDb.prepare('SELECT Name FROM Artist');
console.log(stmt.all());

With database downloaded from https://github.com/lerocha/chinook-database/releases

You're likely using WAL, see #1066 (comment) and #939 (comment)

@JoshuaWise maybe serialize could detect that and throw a more descriptive error? At least the docs should be updated.

[lukeschaefer]

You're likely using WAL

Yup, you're dead on, thanks for the quick assessment. Rebuilding the DB without using WAL fixed the issue.