chore: update usage of deprecated FindObjectsByType<T>(FindObjectsSortMode) and enum FindObjectSortMode #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmandM
reviewed
Jan 26, 2026
Member
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
I love love love this cleanup! 
com.unity.netcode.gameobjects/Tests/Runtime/Prefabs/NetworkPrefabHandlerTests.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Manual/SceneTransitioningAdditive/NetworkManagerMonitor.cs
Outdated
Show resolved
Hide resolved
testproject/Assets/Tests/Manual/SceneTransitioningAdditive/NetworkManagerMonitor.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
mnachury-unity
approved these changes
Jan 26, 2026
EmandM
approved these changes
Jan 28, 2026
Member
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
I love love love the latest name here!
Member
|
@NoelStephensUnity the trunk PR landed so we can try to run CI for 6000.4 and trunk to double check if it works now |
NoelStephensUnity
deleted the
chore/findobjectsbytype-no-more-sorting-update
branch
michalChrobot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…tMode) and enum FindObjectSortMode (#3857) * update Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType. * update Making FindObjects internal. * update Adjusted to explicit handling of the update within test project script to avoid having to make FindObjects public. * update Adding [MethodImpl(MethodImplOptions.AggressiveInlining)] attribute to the T[] FindObjectsByType<T>() method. * style Removing unused using directives. Removing CR. * Update com.unity.netcode.gameobjects/Runtime/Core/FindObjects.cs Co-authored-by: Emma <emma.mcmillan@unity3d.com> * update Adding same condition define, NGO_FINDOBJECTS_NOSORTING, to the testproject.manualtests assembly define. * update Added more precise Unity engine versions to asmdef files to assure earlier versions of 6000.4 and 6000.5 still use the previous API. Renamed FindObjects.FindObjectsByType to FindObjects.ByType Updated FindObject.ByType to be able to sort by identifier and include inactive objects. * update Adding sort by identifier to two locations that require sorting by identifier. * style Added missing whitespace * update increasing the 6000.5 version from 5.0a6 to 5.0a7 as it appears trunk is currently 5.0a6 (which doesn't have the deprecation merged into it yet). * update updating minimum for deprecated fix to 6000.5.0a8. * update This "should" fix the Rust server issue... I think? (Tested local instance on 6000.5.0a7 and it passes everything) * update adding change log entry * update Re-targeting 6000.5.0a7 as the version of unity with the FindObjectsByType changes. * update Moving changelog entry into the unreleased section. --------- Co-authored-by: Emma <emma.mcmillan@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Making adjustments to the changes in
FindObjectsByTypethat no longer supportsFindObjectSortMode. Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes toFindObjectsByType.Jira ticket
MTT-14339
Changelog
FindObjectsByType(FindObjectsSortMode)and enumFindObjectSortModein 6000.4 and 6000.5.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneUnityEngine.FindObjectsSortMode.UnityEngine.FindObjectsSortMode.UnityEngine.FindObjectsSortMode.UnityEngine.FindObjectsSortMode.Automated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No back port required since this is specific to 6000.4 & 6000.5.